17:18
checkasm: add test for fdct Reviewed-by: Martin Storsjö <martinⓐmartin.st> Reviewed-by: Rémi Denis-Courmont <remiⓐremlab.net> [DH] tests/checkasm/Makefile [DH] tests/checkasm/checkasm.c [DH] tests/checkasm/checkasm.h [DH] tests/checkasm/fdctdsp.c [DH] tests/fate/checkasm.mak
15:25
tests/checkasm/svq1enc: Use proper range for input ssd_int8_vs_int16 is only called from encode_block() in svq1enc.c; it calls it in stages: At stage 0, the int16_t array contains the difference of two uint16_t. At each of the following stages, the int16_t array is filled by subtracting an int8_t from the current stage's int16_t array. The maximum stage is five, so the int16_t are in the range (-255 - 5 * 127)..(255 + 5 * 128). This commit modifies the checkasm test to only use values from this range, fixing (undefined) integer overflow in the test. Signed-off-by: Andreas Rheinhardt (...)
03:59
lavd/v4l2: Use proper field type for second parameter of ioctl() with BSD's The proper type was used until 73251678c83cbe24d08264da693411b166239bc7. This covers all of the OS's that currently have V4L2 support, permutations of Linux glibc/musl, Android bionic, FreeBSD, NetBSD, OpenBSD, Solaris. Copied from FreeBSD ports patch. Signed-off-by: Brad Smith <bradⓐcomstyle.com> Signed-off-by: Marton Balint <cusⓐpasswd.hu> [DH] libavdevice/v4l2.c
15:38
avutil/opt: free the temporary layout in av_opt_is_set_to_default() Signed-off-by: James Almer <jamrialⓐgmail.com> [DH] libavutil/opt.c
15:24
avutil/opt: propagate av_dict_copy() errors in av_opt_get,set_dict_val() Signed-off-by: James Almer <jamrialⓐgmail.com> [DH] libavutil/opt.c
15:24
avutil/opt: don't set a channel layout if the option is flagged as read only Signed-off-by: James Almer <jamrialⓐgmail.com> [DH] libavutil/opt.c
15:23
avutil/opt: add a note about the av_opt_get,set_chlayout() behavior Based on the one for av_opt_set_dict_val(). Signed-off-by: James Almer <jamrialⓐgmail.com> [DH] libavutil/opt.h
21:42
avcodec/diracdec: Don't use EDGE_WIDTH from mpegpicture.h There is nothing that forces us to use the same value as mpegvideo_enc.c, so define our own constant. Reviewed-by: Lynne <devⓐlynne.ee> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardtⓐoutlook.com> [DH] libavcodec/diracdec.c
22:33
avcodec/aac/aacdec: Fix linking errors with only one decoder enabled This is achieved by using function pointers for AAC SBR functions. This unfortunately necessitated to use void* in ff_aac_sbr_apply(_fixed). Fixes ticket #10999. Reviewed-by: Lynne <devⓐlynne.ee> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardtⓐoutlook.com> [DH] libavcodec/aac/aacdec.c [DH] libavcodec/aac/aacdec.h [DH] libavcodec/aac/aacdec_proc_template.c [DH] libavcodec/aacsbr.h [DH] (...)
09:49
avcodec/aac/aacdec: Avoid branch to set sample_fmt Reviewed-by: Lynne <devⓐlynne.ee> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardtⓐoutlook.com> [DH] libavcodec/aac/aacdec.c
09:43
avcodec/aac/aacdec: Move channel number check out of init_dsp() Also move initializing random_state. Reviewed-by: Lynne <devⓐlynne.ee> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardtⓐoutlook.com> [DH] libavcodec/aac/aacdec.c
09:31
avcodec/aac/aacdec: Remove unnecessary ff_thread_once() ff_aacdec_common_init_once() already uses its own AVOnce. Reviewed-by: Lynne <devⓐlynne.ee> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardtⓐoutlook.com> [DH] libavcodec/aac/aacdec.c
08:37
avcodec/aacsbr: Fix type mismatch ff_aac_sbr_apply() and ff_aac_sbr_apply_fixed() still used pointers to INTFLOAT which is float or int depending upon whether USE_FIXED is set or not; in particular, according to these declarations both functions have the same type. But that is wrong and given that aacdec.c sets USE_FIXED, it sees the wrong type for ff_aac_sbr_apply(). This leads to a -Wlto-type-mismatch warning when using lto [1]. Fix this by avoiding INTFLOAT in aacsbr.h (which also means that aac_defines.h need not be included there any more). [1]: (...)
08:25
avcodec/aactab: Provide ff_ltp_coef, ff_tns_tmp2_map unconditionally The fixed point decoder needs it since 905fdb06010e554262fca3c12b362bb69a11de85. Reviewed-by: Lynne <devⓐlynne.ee> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardtⓐoutlook.com> [DH] libavcodec/aactab.c
11:59
avcodec/aac/aacdec_(fixed|float): Set AACDecDSP, AACDecProc directly This is more in line with how we initialize DSP functions and avoids tables of function pointers as well as relocations for these. Reviewed-by: Lynne <devⓐlynne.ee> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardtⓐoutlook.com> [DH] libavcodec/aac/aacdec_dsp_template.c [DH] libavcodec/aac/aacdec_fixed.c [DH] libavcodec/aac/aacdec_float.c [DH] libavcodec/aac/aacdec_proc_template.c
11:28
avcodec/aac/aacdec: Move init functions to aacdec_fixed/float This allows to merge it with AACDecDSP.init and remove the latter (it is called only once anyway); it also allows to make the fixed/float AACDecDSP and AACDecProc implementations internal to aacdec_fixed/float.c (which also fixes a violation of our naming conventions). And it some linker errors when either decoder is disabled. Reviewed-by: Lynne <devⓐlynne.ee> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardtⓐoutlook.com> [DH] libavcodec/aac/aacdec.c [DH] libavcodec/aac/aacdec.h [DH] (...)
10:45
avcodec/aac/aacdec: Avoid compiling latm decoder if disabled Reviewed-by: Lynne <devⓐlynne.ee> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardtⓐoutlook.com> [DH] libavcodec/aac/aacdec.c
10:24
avcodec/aac/aacdec: Mark flush as cold Reviewed-by: Lynne <devⓐlynne.ee> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardtⓐoutlook.com> [DH] libavcodec/aac/aacdec.c
10:18
avcodec/aac/aacdec_(fixed|float): Avoid AAC_RENAME, INTFLOAT Unnecessary now that this has been detemplatized. Reviewed-by: Lynne <devⓐlynne.ee> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardtⓐoutlook.com> [DH] libavcodec/aac/aacdec_fixed.c [DH] libavcodec/aac/aacdec_float.c
10:12
avcodec/aac/aacdec_float: Call ff_aac_float_common_init() only once That's enough. Reviewed-by: Lynne <devⓐlynne.ee> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardtⓐoutlook.com> [DH] libavcodec/aac/aacdec_float.c