17:21
configure: filter link flags separately for MSVC This avoids adding flags that cl.exe doesn't understand. Fixes cases where external libraries pkg-config file adds `-L` to the cflags, strip it before passing to cl.exe. Signed-off-by: Kacper Michajłow <kasper93ⓐgmail.com> [DH] configure
13:26
configure: treat unrecognized flags as errors on MSVC This is important for feature checking to work correctly. It can happen that an unrecognized flag passes the compile test with only a warning, while failing in preprocessor-only check with an error. This causes all test_cpp calls to fail and silently produces arguably broken MSVC builds. Also, all check_* functions don't work as expected, because they assume the check passed, even though there was a warning. Additionally, this brings the behavior in line with GCC/Clang based builds, failing early on unrecognized flags instead of (...)
18:43
avfilter/af_afade: factorize functions generating frames No change in functionality. Signed-off-by: Marton Balint <cusⓐpasswd.hu> [DH] libavfilter/af_afade.c
19:48
avfilter/af_afade: rework crossfade activate logic The new logic should be easier to follow. It also uses ff_inlink_consume_frame() for all simple passthrough operations making custom get_audio_buffer callback unnecessary. Fate changes are because the new logic does not repacketize input audio up until the crossfade. Content is the same. Signed-off-by: Marton Balint <cusⓐpasswd.hu> [DH] libavfilter/af_afade.c [DH] tests/ref/fate/filter-acrossfade
18:50
avfilter/af_afade: fix check_input for empty streams Use ff_outlink_get_status directly to get pending EOF state. Fixes assertion failure with: ffmpeg -lavfi "sine=f=1000:d=2[a];sine=f=440:d=2,atrim=end=0[b];[a][b]acrossfade=d=1" -f framecrc - ffmpeg -lavfi "sine=f=1000:d=2,atrim=end=0[a];sine=f=440:d=2[b];[a][b]acrossfade=d=1" -f framecrc - Signed-off-by: Marton Balint <cusⓐpasswd.hu> [DH] libavfilter/af_afade.c
23:44
avcodec/x86/vc1: guard usage of undefined functions with preprocessor The asumption is that DCE will remove references to those functions. However some compilers with certain instrumentation enabled doesn't DCE those at all, resulting in linking failure. Tested with cl.exe -RTCu -RTCs. Signed-off-by: Kacper Michajłow <kasper93ⓐgmail.com> [DH] libavcodec/x86/vc1dsp.h [DH] libavcodec/x86/vc1dsp_init.c
23:40
avcodec/x86/fdct: guard usage of undefined functions with preprocessor The asumption is that DCE will remove references to those functions. However some compilers with certain instrumentation enabled doesn't DCE those at all, resulting in linking failure. Tested with cl.exe -RTCu -RTCs. Signed-off-by: Kacper Michajłow <kasper93ⓐgmail.com> [DH] libavcodec/x86/fdctdsp_init.c
23:45
avformat/rtmpproto: guard usage of undefined functions with preprocessor The asumption is that DCE will remove references to those functions. However some compilers with certain instrumentation enabled doesn't DCE those at all, resulting in linking failure. Tested with cl.exe -RTCu -RTCs. Signed-off-by: Kacper Michajłow <kasper93ⓐgmail.com> [DH] libavformat/rtmpproto.c
14:27
configure: suppress Wmicrosoft-enum-forward-reference Clang-CL complains about fwd references of enums, but we do use it everywhere, so ignore this. Signed-off-by: Kacper Michajłow <kasper93ⓐgmail.com> [DH] configure