Recherche avancée

Sur d’autres sites (10178)

• avutils/hwcontext : When deriving a hwdevice, search for existing device in both direc...

  25 novembre 2021, par Soft Works

  avutils/hwcontext : When deriving a hwdevice, search for existing device in both directions
  The test /libavutil/tests/hwdevice checks that when deriving a device
  
  from a source device and then deriving back to the type of the source
  
  device, the result is matching the original source device, i.e. the
  
  derivation mechanism doesn't create a new device in this case.
  Previously, this test was usually passed, but only due to two different
  
  kind of flaws :
  1. The test covers only a single level of derivation (and back)
  It derives device Y from device X and then Y back to the type of X and
  
  checks whether the result matches X.
  What it doesn't check for, are longer chains of derivation like :
  CUDA1 > OpenCL2 > CUDA3 and then back to OpenCL4
  In that case, the second derivation returns the first device (CUDA3 ==
  
  CUDA1), but when deriving OpenCL4, hwcontext.c was creating a new
  
  OpenCL4 context instead of returning OpenCL2, because there was no link
  
  from CUDA1 to OpenCL2 (only backwards from OpenCL2 to CUDA1)
  If the test would check for two levels of derivation, it would have
  
  failed.
  This patch fixes those (yet untested) cases by introducing forward
  
  references (derived_device) in addition to the existing back references
  
  (source_device).
  2. hwcontext_qsv didn't properly set the source_device
  In case of QSV, hwcontext_qsv creates a source context internally
  
  (vaapi, dxva2 or d3d11va) without calling av_hwdevice_ctx_create_derived
  
  and without setting source_device.
  This way, the hwcontext test ran successful, but what practically
  
  happened, was that - for example - deriving vaapi from qsv didn't return
  
  the original underlying vaapi device and a new one was created instead :
  
  Exactly what the test is intended to detect and prevent. It just
  
  couldn't do so, because the original device was hidden (= not set as the
  
  source_device of the QSV device).
  This patch properly makes these setting and fixes all derivation
  
  scenarios.
  (at a later stage, /libavutil/tests/hwdevice should be extended to check
  
  longer derivation chains as well)
  Reviewed-by : Lynne <dev@lynne.ee>
  
  Reviewed-by : Anton Khirnov <anton@khirnov.net>
  
  Tested-by : Wenbin Chen <wenbin.chen@intel.com>
  
  Signed-off-by : softworkz <softworkz@hotmail.com>
  
  Signed-off-by : Haihao Xiang <haihao.xiang@intel.com>
  

  • [DH] libavutil/hwcontext.c
  • [DH] libavutil/hwcontext.h
  • [DH] libavutil/hwcontext_internal.h
  • [DH] libavutil/hwcontext_qsv.c

• avutil/x86/emms : Don't unnecessarily include lavu/cpu.h

  30 juillet 2021, par Andreas Rheinhardt

  avutil/x86/emms : Don't unnecessarily include lavu/cpu.h
  Only include it if it is needed, namely if __MMX__ is undefined.
  X86 is currently the only arch where lavu/cpu.h is basically
  
  automatically included (for internal development) : #if ARCH_X86
  
  is true, lavu/internal.h (which is basically included everywhere)
  
  includes lavu/x86/emms.h which can mask missing inclusions
  
  of lavu/cpu.h if the developer works on x86/x64. This has happened
  
  in 8e825ec3ab09d877f12dcf05d76902a8bb9c8b11 and also earlier
  
  (see 6d2365882f281f9452b31b91edb2e6a2d4f5ff08).
  
  By including said header only if necessary ordinary developer machines
  
  will behave like non-x86 arches, so that missing inclusions of cpu.h
  
  won't go unnoticed any more.
  Signed-off-by : Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
  

  • [DH] libavutil/x86/emms.h

• avcodec/libkvazaar : Increase array size

  6 décembre 2021, par Andreas Rheinhardt

  avcodec/libkvazaar : Increase array size
  av_image_copy() expects an array of four pointers according to its
  
  declaration ; although it currently only touches pointers that
  
  are actually in use (depending upon the pixel format) this might
  
  change at any time (as has already happened for the linesizes
  
  in d7bc52bf456deba0f32d9fe5c288ec441f1ebef5).
  This fixes a -Wstringop-overflow= warning with GCC 11.2.
  Signed-off-by : Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
  

  • [DH] libavcodec/libkvazaar.c