git.videolan.org Git - ffmpeg.git/rss log

Les articles publiés sur le site

• configure : Enable -fno-common for Darwin targets, avoid linker warnings

  29 avril, par Martin Storsjö

  configure: Enable -fno-common for Darwin targets, avoid linker warnings
  
  Since GCC 10 and llvm.org Clang 11, -fno-common is the default.
  However Apple's Xcode Clang hasn't followed suit yet, and still
  defaults to -fcommon.
  
  Compiling with -fcommon causes uninitialized global variables to
  be treated as "common" (which allows multiple object files to have
  similar definitions).
  
  Common variables seem to have the issue that their intended alignment
  isn't signaled, so the linker assumes that they may need alignment
  according to their full size.
  
  With large global tables, this can lead to linker warnings like
  this, with Xcode 16.3:
  
      ld: warning: reducing alignment of section __DATA,__common from 0x8000 to 0x4000 because it exceeds segment maximum alignment
  
  This can be reproduced with a small snippet like this:
  
      char table[16385];
      int main(int argc, char* argv[]) { return 0; }
  
  Compiling with -fno-common avoids this issue and warning, and
  matches the default behaviour of other compilers. (Compiling with
  -fno-common also avoids the risk of accidentally accepting
  duplicate definitions of global variables, as long as they are
  uninitialized.)
  
  Signed-off-by: Martin Storsjö <martin@martin.st>
  

  • [DH] configure

• hwcontext_vulkan : support AV_PIX_FMT_GBRP

  29 avril, par Lynne

  hwcontext_vulkan: support AV_PIX_FMT_GBRP
  
  Support was partially added previously in vulkan.c, but now it's fully
  supported.
  

  • [DH] libavutil/hwcontext_vulkan.c
  • [DH] libavutil/vulkan.c

• fftools/textformat : Add flags param to function avtext_print_integer()

  29 avril, par softworkz

  fftools/textformat: Add flags param to function avtext_print_integer()
  
  Make this function work analog to avtext_print_string() which already
  has a flags parameter.
  
  Signed-off-by: softworkz <softworkz@hotmail.com>
  

  • [DH] fftools/ffprobe.c
  • [DH] fftools/textformat/avtextformat.c
  • [DH] fftools/textformat/avtextformat.h

• fftools/textformat : Apply quality improvements

  29 avril, par softworkz

  fftools/textformat: Apply quality improvements
  
  Perform multiple improvements to increase code robustness.
  In particular:
  - favor unsigned counters for loops
  - add missing checks
  - avoid possible leaks
  - move variable declarations to inner scopes when feasible
  - provide explicit type-casting when needed
  
  Signed-off-by: softworkz <softworkz@hotmail.com>
  

  • [DH] fftools/textformat/avtextformat.c
  • [DH] fftools/textformat/avtextformat.h
  • [DH] fftools/textformat/tf_default.c
  • [DH] fftools/textformat/tf_ini.c
  • [DH] fftools/textformat/tf_json.c
  • [DH] fftools/textformat/tf_xml.c
  • [DH] fftools/textformat/tw_avio.c

• fftools/textformat : Introduce common header and deduplicate code

  28 avril, par softworkz

  fftools/textformat: Introduce common header and deduplicate code
  
  Also change writer_printf signature in AVTextWriter to use va_list,
  so that it can be called by the new function writer_printf()
  in tf_internal.h.
  
  Reviewed-by: Stefano Sabatini <stefasab@gmail.com>
  Signed-off-by: softworkz <softworkz@hotmail.com>
  

  • [DH] fftools/textformat/avtextwriters.h
  • [DH] fftools/textformat/tf_compact.c
  • [DH] fftools/textformat/tf_default.c
  • [DH] fftools/textformat/tf_flat.c
  • [DH] fftools/textformat/tf_ini.c
  • [DH] fftools/textformat/tf_internal.h
  • [DH] fftools/textformat/tf_json.c
  • [DH] fftools/textformat/tf_xml.c
  • [DH] fftools/textformat/tw_avio.c
  • [DH] fftools/textformat/tw_buffer.c
  • [DH] fftools/textformat/tw_stdout.c