Xiph.org - flac.git/summary

Les articles publiés sur le site

• libFLAC : Set decoding status if write callback failed

  13 juillet 2016, par Erik de Castro Lopo

  libFLAC: Set decoding status if write callback failed
  
  Previously, it the write callback failed the error status
  would be set to `FLAC__STREAM_DECODER_READ_FRAME`. Now it
  gets set to `FLAC__STREAM_DECODER_WRITE_STATUS_ABORT`.
  
  Patch-from: lvqcl <lvqcl.mail@gmail.com>
  

  • [DH] include/FLAC/stream_decoder.h
  • [DH] src/libFLAC/stream_decoder.c

• libFLAC/metadata_object.c : Clean up

  10 juillet 2016, par Erik de Castro Lopo

  libFLAC/metadata_object.c: Clean up
  
  * Remove Yoda conditionals.
  * Drop some un-needed asserts.
  

  • [DH] src/libFLAC/metadata_object.c

• metadata_object.c : Remove un-needed asserts

  10 juillet 2016, par Erik de Castro Lopo

  metadata_object.c: Remove un-needed asserts
  
  These asserts were being triggered by AFL (American Fuzzy Lop) and
  serve seemingly no useful purpose. The are only enabled in debug builds
  where they abort the program which is otherwise in a safe state.
  
  Removing these asserts will potentially allow AFL to turn up other
  problems elsewhere.
  

  • [DH] src/libFLAC/metadata_object.c

• flac++.pc.in : Make flac a private requires

  9 juillet 2016, par Erik de Castro Lopo

  flac++.pc.in: Make flac a private requires
  
  Patch pulled from Debian package.
  
  Description:
  Chain::Status::as_cstring uses FLAC__Metadata_ChainStatusString which
  is in libFLAC. Since the function is inline, every program calling
  this function must also link with -lflac, but this is missing in
  flac++.pc.
  
  Bug-Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=713645
  

  • [DH] src/libFLAC++/flac++.pc.in

• stream_decoder : fix integer underflow due to malformed wasted_bits

  8 juillet 2016, par Max Kellermann

  stream_decoder: fix integer underflow due to malformed wasted_bits
  
  It is pretty easy for a malformed FLAC file to underflow the "bps"
  variable.  In the debug build, this results in an assertion failure in
  FLAC__bitreader_read_raw_uint32():
  
      FLAC__ASSERT(bits <= 32);
  
  In non-debug builds, this simply makes
  FLAC__bitreader_read_raw_uint32() fail because
  bitreader_read_from_client_() doesn't find enough buffer space for
  2**32-1 bits.  But since the failing FLAC_ASSERT() is reasonable, this
  should be caught in the FLAC__bitreader_read_raw_uint32() caller.
  
  Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>
  Closes: https://github.com/xiph/flac/pull/13
  

  • [DH] src/libFLAC/stream_decoder.c