Recherche avancée

Sur d’autres sites (6502)

• avformat/dashdec : Fix leak of string on error when parsing representation

  19 septembre 2020, par Andreas Rheinhardt

  avformat/dashdec : Fix leak of string on error when parsing representation
  The DASH demuxer currently extracts several strings at once from an xml
  
  document before processing them one by one ; these strings are allocated,
  
  stored in local variables and need to be freed by the demuxer itself.
  
  So if an error happens when processing one of them, all strings need to
  
  be freed before returning. This has simply not been done, leading to
  
  leaks.
  A simple fix would be to add the necessary code for freeing ; yet there is
  
  a better solution : Avoid having several strings at the same time by
  
  extracting a string, processing it and immediately freeing it. That way
  
  one only has to free at most one string on error.
  Reviewed-by : Steven Liu <lq@chinaffmpeg.org>
  
  Signed-off-by : Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
  

  • [DH] libavformat/dashdec.c

• avformat/hlsenc : Fix leak of options when initializing muxing fails

  16 décembre 2019, par Andreas Rheinhardt

  avformat/hlsenc : Fix leak of options when initializing muxing fails
  hls_mux_init() currently leaks an AVDictionary if opening a dynamic
  
  buffer fails or if avformat_init_output fails. This has been fixed by
  
  moving the initialization resp. the freeing of the dictionary around :
  
  In the former case to a place after opening the dynamic buffer, in the
  
  latter to a place before the check for initialization failure so that it
  
  is done unconditionally.
  Furthermore, the dictionary is now only copied and freed if the options
  
  in it are actually used (namely when in SEGMENT_TYPE_FMP4 mode).
  Finally, a similar situation in hls_start() has been fixed, too.
  Signed-off-by : Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
  
  Reviewed-by : Steven Liu <lq@onvideo.cn>
  

  • [DH] libavformat/hlsenc.c

• OpenCV Mat to ffmpeg AVPicture conversion memory leak

  13 août 2015, par Pavel

  I have next code :

  void matToAvPicture(cv::Mat frame, AVPicture *picture)
  
  {
  
      cv::resize(frame, frame, cv::Size(m_streamWidth, m_streamHeight));
  
      uint8_t* buf = (uint8_t*)malloc(avpicture_get_size(AV_PIX_FMT_BGR24, m_streamWidth, m_streamHeight)); // 3 bytes per pixel
  
      for(int i = 0; i < m_streamHeight; i++)
  
      {
  
          memcpy(&(buf[i * m_streamWidth * 3]), &(frame.data[i * frame.step]), m_streamWidth * 3);
  
      }
  
      AVPicture bgrPicture;
  
      avpicture_alloc(&bgrPicture, AV_PIX_FMT_BGR24, m_streamWidth, m_streamHeight);
  
      avpicture_fill(&bgrPicture, buf, AV_PIX_FMT_BGR24, m_streamWidth, m_streamHeight);
  
      sws_scale(rgbToYuvContext, (const uint8_t * const *)bgrPicture.data, bgrPicture.linesize, 0, m_streamHeight, picture->data, picture->linesize);
  
      avpicture_free(&bgrPicture);
  
  //    free(buf);
  
  }

  But call of avpicture_free(&bgrPicture) doesn’t free memory completely. If I commented line avpicture_fill(&bgrPicture, buf, AV_PIX_FMT_BGR24, m_streamWidth, m_streamHeight); and uncommented line
  free(buf)
  memory leak doesn’t appear.
  What is the problem ?