Recherche avancée

Sur d’autres sites (2149)

• avutil/frame : Return 0 on success in av_frame_ref()

  1er avril 2021, par Andreas Rheinhardt

  avutil/frame : Return 0 on success in av_frame_ref()
  av_frame_copy() is allowed to return values >= 0 on success, whereas
  
  the documentation of av_frame_ref() states that the return value is 0 on
  
  success. Ergo the latter must not just return the former's return value.
  Signed-off-by : Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
  

  • [DH] libavutil/frame.c

• avcodec/avcodec : Use avcodec_close() on avcodec_open2() failure

  28 avril 2021, par Andreas Rheinhardt

  avcodec/avcodec : Use avcodec_close() on avcodec_open2() failure
  Compared to the earlier behaviour the following changes :
  
  a) AVCodecInternal.byte_buffer is freed.
  
  b) The last_pkt_props FIFO is emptied before freeing it.
  
  c) If set AVCodecContext.hwaccel is uninitialized and its private data
  
  is freed ; hw_frames_ctx and hw_device_ctx are also unreferenced.
  
  d) coded_side_data is freed.
  
  e) active_thread_type is reset.
  
  a), b), d) should be no-ops as the buffer/fifo should be empty and
  
  no coded_side_data should exist at any point of avcodec_open2().
  
  e) is obviously not bad.
  
  c) is in accordance with the documentation of hw_(frames|device)_ctx
  
  which states that libacodec takes over ownership of these references.
  
  At least in the case of VC-1 it is possible for the hw acceleration to
  
  be set during init and in this case freeing it actually fixes a memleak.
  avcodec_close() needed only minor adjustments to make it work with
  
  a potentially not fully initialized codec.
  Signed-off-by : Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
  

  • [DH] libavcodec/avcodec.c

• avformat/mpegtsenc : Fix mpegts_write_pes() for private_stream_2 and other types

  25 avril 2021, par zheng qian

  avformat/mpegtsenc : Fix mpegts_write_pes() for private_stream_2 and other types
  According to the PES packet definition defined in Table 2-17 of ISO_IEC_13818-1
  
  specification, some fields like PTS/DTS or pes_extension could only appears if
  
  the stream_id meets the condition :
  if (stream_id != 0xBC &&  // program_stream_map
  
      stream_id != 0xBE &&  // padding_stream
  
      stream_id != 0xBF &&  // private_stream_2
  
      stream_id != 0xF0 &&  // ECM
  
      stream_id != 0xF1 &&  // EMM
  
      stream_id != 0xFF &&  // program_stream_directory
  
      stream_id != 0xF2 &&  // DSMCC_stream
  
      stream_id != 0xF8)    // ITU-T Rec. H.222.1 type E stream
  And the following stream_id types don't have fields like PTS/DTS :
  else if ( stream_id == program_stream_map
  
  || stream_id == private_stream_2
  
  || stream_id == ECM
  
  || stream_id == EMM
  
  || stream_id == program_stream_directory
  
  || stream_id == DSMCC_stream
  
  || stream_id == ITU-T Rec. H.222.1 type E stream ) 
  
      for (i = 0 ; i < PES_packet_length ; i++) 
  
          PES_packet_data_byte
  
      
  
  
  Current implementation skipped the check of stream_id causing some kind of
  
  streams like private_stream_2 to be incorrectly written with actually a
  
  private_stream_1-like PES header with PTS/DTS field. For example, Japan DTV
  
  transmits news and alerts through ARIB superimpose that utilizes
  
  private_stream_2 still could not be remuxed correctly for now.
  This patch set fixes the remuxing for private_stream_2 and
  
  other stream_id types.
  Signed-off-by : zheng qian <xqq@xqq.im>
  
  Signed-off-by : Marton Balint <cus@passwd.hu>
  

  • [DH] libavformat/mpegtsenc.c