Recherche avancée

Sur d’autres sites (13542)

• avfilter/vf_alphamerge : Fix double-free of AVFilterFormats on error

  7 août 2020, par Andreas Rheinhardt

  avfilter/vf_alphamerge : Fix double-free of AVFilterFormats on error
  The query_formats function of the alphamerge filter tries to allocate
  
  two lists of formats which on success are attached to more permanent
  
  objects (AVFilterLinks) for storage afterwards. If attaching a list
  
  to an AVFilterLink succeeds, the link becomes one of the owners of
  
  the list. Yet if attaching a list to one of its links succeeds and
  
  an error happens lateron, both lists were manually freed, which is wrong
  
  if the list is already owned by one or more links ; these links' pointers
  
  to their lists will become dangling and there will be a double-free/use-
  
  after-free when these links are cleaned up automatically.
  This commit fixes this by removing the custom freeing code ; this will
  
  temporarily add a leaking codepath (if attaching a list not already
  
  owned by a link to a link fails, the list will leak), but this will
  
  be fixed soon by making sure that an AVFilterFormats without owner will
  
  be automatically freed when attaching it to an AVFilterLink fails.
  
  At most one list leaks because as of this commit a new list is only
  
  allocated after the old list has been successfully attached to a link.
  Reviewed-by : Nicolas George <george@nsup.org>
  
  Signed-off-by : Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
  

  • [DH] libavfilter/vf_alphamerge.c

• cbs : Describe allocate/free methods in tabular form

  27 juillet 2020, par Mark Thompson

  cbs : Describe allocate/free methods in tabular form
  Unit types are split into three categories, depending on how their
  
  content is managed :
  
  * POD structure - these require no special treatment.
  
  * Structure containing references to refcounted buffers - these can use
  
    a common free function when the offsets of all the internal references
  
    are known.
  
  * More complex structures - these still require ad-hoc treatment.
  For each codec we can then maintain a table of descriptors for each set of
  
  equivalent unit types, defining the mechanism needed to allocate/free that
  
  unit content.  This is not required to be used immediately - a new alloc
  
  function supports this, but does not replace the old one which works without
  
  referring to these tables.
  

  • [DH] libavcodec/cbs.c
  • [DH] libavcodec/cbs.h
  • [DH] libavcodec/cbs_internal.h

• avformat/mov : free HEIFItem.name when cleaning items in mov_read_trak

  26 mars 2024, par James Almer

  avformat/mov : free HEIFItem.name when cleaning items in mov_read_trak
  Fixes memleaks.
  Signed-off-by : James Almer <jamrial@gmail.com>
  

  • [DH] libavformat/mov.c