Recherche avancée

Sur d’autres sites (8684)

• avformat/iamf_writer : Fix leaks on error

  19 février 2024, par Andreas Rheinhardt

  avformat/iamf_writer : Fix leaks on error
  Fixes Coverity issues #1559544 and #1559547.
  Reviewed-by : James Almer <jamrial@gmail.com>
  
  Signed-off-by : Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
  

  • [DH] libavformat/iamf_writer.c

• avcodec/movtextdec : Fix leaks on (re)allocation failure

  17 octobre 2020, par Andreas Rheinhardt

  avcodec/movtextdec : Fix leaks on (re)allocation failure
  Up until now, the 3GPP Timed Text decoder used av_dynarray_add()
  
  for a list of style entries. Said entries are individually allocated
  
  and owned by the pointers in the dynamic array and are therefore
  
  unsuitable for av_dynarray_add() which simply frees the array,
  
  but not the entries on error. In this case the intended new entry
  
  also leaks because it has been forgotten to free it.
  This commit fixes this. It is now allocated in one go and not
  
  reallocated multiple times (and it won't be overallocated any more).
  
  After all, the final number of elements (pending errors) is already
  
  known in advance.
  Furthermore, the style entries are now the entries of the new array,
  
  i.e. they are no longer allocated separately. This also removes one
  
  level of indirection.
  Reviewed-by : Philip Langdale <philipl@overt.org>
  
  Signed-off-by : Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
  

  • [DH] libavcodec/movtextdec.c

• ffmpeg(libavcodec). memory leaks in avcodec_encode_video

  31 mars 2012, par gavlig

  I'm trying to transcode a video with help of libavcodec.
  On transcoding big video files(hour or more) i get huge memory leaks in avcodec_encode_video. I have tried to debug it, but with different video files different functions produce leaks, i have got a little bit confused about that :). Here FFMPEG with QT memory leak is the same issue that i have, but i have no idea how did that person solve it. QtFFmpegwrapper seems to do the same i do(or i missed something).

  my method is lower. I took care about aFrame and aPacket outside with av_free and av_free_packet.

  int
  
  Videocut::encode(
  
  AVStream *anOutputStream,
  
  AVFrame *aFrame,
  
  AVPacket *aPacket
  
  )
  
  {
  
  AVCodecContext *outputCodec = anOutputStream->codec;
  
  
  
  if (!anOutputStream ||
  
      !aFrame ||
  
      !aPacket)
  
  {
  
      return 1;
  
      /* NOTREACHED */
  
  }
  
  
  
  uint8_t * buffer = (uint8_t *)malloc(
  
      sizeof(uint8_t) * _DefaultEncodeBufferSize
  
      );
  
  
  
      if (NULL == buffer) {
  
          return 2;
  
          /* NOTREACHED */
  
  }
  
  
  
  int packetSize = avcodec_encode_video(
  
      outputCodec,
  
          buffer,
  
          _DefaultEncodeBufferSize,
  
          aFrame
  
      );
  
  
  
  if (packetSize < 0) {
  
      free(buffer);
  
      return 1;
  
      /* NOTREACHED */
  
  }
  
  
  
  aPacket->data = buffer;
  
  aPacket->size = packetSize;
  
  
  
  return 0;
  
  }