Recherche avancée

Sur d’autres sites (3499)

• Revision 3606b78108 : Modified test for auto key frame detection. The existing test was triggering a

  16 avril 2015, par paulwilkins

  Changed Paths :
   Modify /vp9/encoder/vp9_firstpass.c

  
  
  Modified test for auto key frame detection.

  The existing test was triggering a lot of false positives on some types
  of animated material with very plain backgrounds. These were triggering
  code designed to catch key frames in letter box format clips.

  This patch tightens up the criteria and imposes a minimum requirement
  on the % blocks coded intra in the first pass and the ratio between the
  % coded intra and the modified inter % after discounting neutral (flat)
  blocks that are coded equally well either way.

  On a particular problem animation clip this change eliminated a large
  number of false positives including some cases where the old code
  selected kf several times in a row. Marginal false negatives are less
  damaging typically to compression and in the problem clip there are now
  a couple of cases where "visual" scene cuts are ignored because of well
  correlated content across the scene cut.

  Replaced some magic numbers related to this with #defines and added
  explanatory comments.

  Change-Id : Ia3d304ac60eb7e4323e3817eaf83b4752cd63ecf

• AAC : Fix M/S stereo encoding

  3 mars 2015, par Claudio Freire

  AAC : Fix M/S stereo encoding
  This patch fixes a pointer arithmetic bug in adjust_frame_information that resulted in heavily corrupted audio when using M/S encoding. Also, a backup copy of untransformed coefficients has to be kept around or attempts at re-processing the frame (which happens when hevavily overspending bits during transients) will result in re-encoding of the coefficients and subsequent corruption of the resulting stream.
  A/B testing shows the bug as corrected, but still cannot prove that M/S coding is a win at least in numbers. Limited listening tests do show improvement on M/S encoded samples in lower bitrates, but they’re hidden among the other artifacts that remain to be corrected in the encoder.
  Some of the regressions flagged in the report do show poor stereo image (but not buggy), so M/S encoding is clearly not good enough yet to be defaulted to auto.
  In numbers, Patched against Unpatched, stereo_mode auto :
    Files : 114
  
    Bitrates : 6
  
    Tests : 683
    Serious Regressions : 0 (0%)
  
    Regressions : 0 (0%)
  
    Improvements : 227 (33%)
  
    Big improvements : 92 (13%)
  
    Worst regression - mybloodrusts.wv - 256k
  
      - StdDev : 28.61       pSNR : -0.43     maxdiff : 1372.00
  
    Best improvement - 60.wv - 384k
  
      - StdDev : -369.57     pSNR : 45.02     maxdiff : -13322.00
  
    Average          - StdDev : -80.56       pSNR : 2.49      maxdiff : -8858.00
  Patched against Unpatched stereo_mode ms_off shows no difference.
  Patched stereo_mode auto vs Unpatched stereo_mode ms_off shows a small average improvement, just not too significant :
    Serious Regressions : 0 (0%)
  
    Regressions : 10 (1%)
  
    Improvements : 45 (6%)
  
    Big improvements : 2 (0%)
  
    Worst regression - Illinois.wv - 256k
  
      - StdDev : 33.20       pSNR : -2.03     maxdiff : 477.00
  
    Best improvement - song_of_circomstances.flac - 384k
  
      - StdDev : -3.97       pSNR : 7.61      maxdiff : -826.00
  
    Average          - StdDev : -10.25       pSNR : 0.20      maxdiff : -281.00
  Signed-off-by : Michael Niedermayer <michaelni@gmx.at>
  

  • [DH] libavcodec/aac.h
  • [DH] libavcodec/aaccoder.c
  • [DH] libavcodec/aacenc.c

• How to write UI tests for your plugin – Introducing the Piwik Platform

  18 février 2015, par Thomas Steur — Development

  This is the next post of our blog series where we introduce the capabilities of the Piwik platform (our previous post was How to write unit tests for your plugin). This time you’ll learn how to write UI tests in Piwik. For this tutorial you will need to have basic knowledge of JavaScript and the Piwik platform.

  What is a UI test ?

  Some might know a UI test under the term ‘CSS test’ or ‘screenshot test’. When we speak of UI tests we mean automated tests that capture a screenshot of a URL and then compare the result with an expected image. If the images are not exactly the same the test will fail. For more information read our blog post about UI Testing.

  What is a UI test good for ?

  We use them to test our PHP Controllers, Twig templates, CSS, and indirectly test our JavaScript. We do usually not write Unit or Integration tests for our controllers. For example we use UI tests to ensure that the installation, the login and the update process works as expected. We also have tests for most pages, reports, settings, etc. This increases the quality of our product and saves us a lot of time as it is easy to write and maintain such tests. All UI tests are executed on Travis after each commit and compared with our expected screenshots.

  Getting started

  In this post, we assume that you have already installed Piwik 2.11.0 or later via git, set up your development environment and created a plugin. If not, visit the Piwik Developer Zone where you’ll find the tutorial Setting up Piwik and other Guides that help you to develop a plugin.

  Next you need to install the needed packages to execute UI tests.

  Let’s create a UI test

  We start by using the Piwik Console to create a new UI test :

  ./console generate:test --testtype ui

  The command will ask you to enter the name of the plugin the created test should belong to. I will use the plugin name “Widgetize”. Next it will ask you for the name of the test. Here you usually enter the name of the page or report you want to test. I will use the name “WidgetizePage” in this example. There should now be a file plugins/Widgetize/tests/UI/WidgetizePage_spec.js which contains already an example to get you started easily :

  describe("WidgetizePage", function () {
  
      var generalParams = 'idSite=1&period=day&date=2010-01-03';
  
  
  
      it('should load a simple page by its module and action', function (done) {
  
          var screenshotName = 'simplePage';
  
          // will save image in "processed-ui-screenshots/WidgetizePageTest_simplePage.png"
  
  
  
          expect.screenshot(screenshotName).to.be.capture(function (page) {
  
              var urlToTest = "?" + generalParams + "&module=Widgetize&action=index";
  
              page.load(urlToTest);
  
          }, done);
  
      });
  
  });

  What is happening here ?

  This example declares a new set of specs by calling the method describe(name, callback) and within that a new spec by calling the method it(description, func). Within the spec we load a URL and once loaded capture a screenshot of the whole page. The captured screenshot will be saved under the defined screenshotName. You might have noticed we write our UI tests in BDD style.

  Capturing only a part of the page

  It is good practice to not always capture the full page. For example many pages contain a menu and if you change that menu, all your screenshot tests would fail. To avoid this you would instead have a separate test for your menu. To capture only a part of the page simply specify a jQuery selector and call the method captureSelector instead of capture :

  var contentSelector = '#selector1, .selector2 .selector3';
  
  // Only the content of both selectors will be in visible in the captured screenshot
  
  expect.screenshot('page_partial').to.be.captureSelector(contentSelector, function (page) {
  
      page.load(urlToTest);
  
  }, done);

  Hiding content

  There is a known issue with sparklines that can fail tests randomly. Also version numbers or a date that changes from time to time can fail tests without actually having an error. To avoid this you can prevent elements from being visible in the captured screenshot via CSS as we add a CSS class called uiTest to the HTML element while tests are running.

  .uiTest .version { visibility:hidden }

  Running a test

  To run the previously generated tests we will use the command tests:run-ui :

  ./console tests:run-ui WidgetizePage

  After running the tests for the first time you will notice a new folder plugins/PLUGINNAME/tests/UI/processed-ui-screenshots in your plugin. If everything worked, there will be an image for every captured screenshot. If you’re happy with the result it is time to copy the file over to the expected-ui-screenshots folder, otherwise you have to adjust your test until you get the result you want. From now on, the newly captured screenshots will be compared with the expected images whenever you execute the tests.

  Fixing a test

  At some point your UI test will fail, for example due to expected CSS changes. To fix a test all you have to do is to copy the captured screenshot from the folder processed-ui-screenshots to the folder expected-ui-screenshots.

  Executing the UI tests on Travis

  In case you have not generated a .travis.yml file for your plugin yet you can do this by executing the following command :

  ./console generate:travis-yml --plugin PLUGINNAME

  Next you have to activate Travis for your repository.

  Advanced features

  Isn’t it easy to create a UI test ? We never even created a file ! Of course you can accomplish even more if you want. For example you can specify a fixture to be inserted before running the tests which is useful when your plugin requires custom data. You can also control the browser as it was a human by clicking, moving the mouse, typing text, etc. If you want to discover more features have a look at our existing test cases.

  If you have any feedback regarding our APIs or our guides in the Developer Zone feel free to send it to us.