Recherche avancée

Sur d’autres sites (8684)

• avformat/avc, mxfenc : Avoid allocation of H264 SPS structure, fix memleak

  24 juin 2020, par Andreas Rheinhardt

  avformat/avc, mxfenc : Avoid allocation of H264 SPS structure, fix memleak
  Up until now, ff_avc_decode_sps would parse a SPS and return some
  
  properties from it in a freshly allocated structure. Yet said structure
  
  is very small and completely internal to libavformat, so there is no
  
  reason to use the heap for it. This commit therefore changes the
  
  function to return an int and to modify a caller-provided structure.
  
  This will also allow ff_avc_decode_sps to return better error codes in
  
  the future.
  It also fixes a memleak in mxfenc : If a packet contained multiple SPS,
  
  only the SPS structure belonging to the last SPS would be freed, the
  
  other ones would leak when the pointer is overwritten to point to the
  
  new SPS structure. Of course, without allocations there are no leaks.
  
  This is Coverity issue #1445194.
  Furthermore, the SPS structure has been renamed from
  
  H264SequenceParameterSet to H264SPS in order to avoid overlong lines.
  Reviewed-by : Tomas Härdin <tjoppen@acc.umu.se>
  
  Signed-off-by : Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
  

  • [DH] libavformat/avc.c
  • [DH] libavformat/avc.h
  • [DH] libavformat/mxfenc.c

• avfilter/vf_overlay : Fix double-free of AVFilterFormats on error

  7 août 2020, par Andreas Rheinhardt

  avfilter/vf_overlay : Fix double-free of AVFilterFormats on error
  The query_formats function of the overlay filter tries to allocate
  
  two lists (only one in a special case) of formats which on success
  
  are attached to more permanent objects (AVFilterLinks) for storage
  
  afterwards. If attaching a list to an AVFilterLink succeeds, it is
  
  in turn owned by the AVFilterLink (or more exactly, the AVFilterLink
  
  becomes one of the common owners of the list). Yet if attaching a list
  
  to one of its links succeeds and an error happens lateron, both lists
  
  were manually freed, whic is wrong if the list is already owned by one
  
  or more links ; these links' pointers to their lists will become dangling
  
  and there will be a double-free/use-after-free when these links are
  
  cleaned up automatically.
  This commit fixes this by removing the custom freeing code ; this will
  
  temporarily add a leaking codepath (if attaching a list not already
  
  owned by a link to a link fails, the list will leak), but this will
  
  be fixed soon by making sure that an AVFilterFormats without owner will
  
  be automatically freed when attaching it to an AVFilterLink fails.
  
  Notice that at most one list leaks because a new list is only allocated
  
  after the old list has been successfully attached to a link.
  Reviewed-by : Nicolas George <george@nsup.org>
  
  Signed-off-by : Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
  

  • [DH] libavfilter/vf_overlay.c

• lavc : add avcodec_free_context().

  5 avril 2014, par Anton Khirnov

  lavc : add avcodec_free_context().
  Right now, the caller has to manually manage some allocated
  
  AVCodecContext fields, like extradata or subtitle_header. This is
  
  fragile and prone to leaks, especially if we want to add more such
  
  fields in the future.
  The only reason for this behaviour is so that the AVStream codec context
  
  can be reused for decoding. Such reuse is discouraged anyway, so this
  
  commit is the first step to deprecating it.
  

  • [DBH] doc/APIchanges
  • [DBH] libavcodec/avcodec.h
  • [DBH] libavcodec/options.c
  • [DBH] libavcodec/version.h