Recherche avancée

Sur d’autres sites (9227)

• avformat/dashdec : Fix leak of string on error when parsing representation

  19 septembre 2020, par Andreas Rheinhardt

  avformat/dashdec : Fix leak of string on error when parsing representation
  The DASH demuxer currently extracts several strings at once from an xml
  
  document before processing them one by one ; these strings are allocated,
  
  stored in local variables and need to be freed by the demuxer itself.
  
  So if an error happens when processing one of them, all strings need to
  
  be freed before returning. This has simply not been done, leading to
  
  leaks.
  A simple fix would be to add the necessary code for freeing ; yet there is
  
  a better solution : Avoid having several strings at the same time by
  
  extracting a string, processing it and immediately freeing it. That way
  
  one only has to free at most one string on error.
  Reviewed-by : Steven Liu <lq@chinaffmpeg.org>
  
  Signed-off-by : Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
  

  • [DH] libavformat/dashdec.c

• avformat/segment : Fix leak of string on error

  5 septembre 2020, par Andreas Rheinhardt

  avformat/segment : Fix leak of string on error
  A string containing the segment's filename that the segment muxer
  
  allocates got only freed in its write_trailer function. This implies
  
  that it leaks if write_trailer is never called, e.g. if initializing
  
  the child muxer fails. This commit fixes this by freeing the string
  
  in the deinit function instead.
  Reviewed-by : Ridley Combs <rcombs@rcombs.me>
  
  Signed-off-by : Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
  

  • [DH] libavformat/segment.c

• avfilter/af_headphone : Simplify parsing channel mapping string

  27 août 2020, par Andreas Rheinhardt

  avfilter/af_headphone : Simplify parsing channel mapping string
  When parsing the channel mapping string (a string containing '|'
  
  delimited tokens each of which is supposed to contain a channel name
  
  like "FR"), the old code would at each step read up to seven uppercase
  
  characters from the input string and give this to
  
  av_get_channel_layout() to parse. The returned layout is then checked
  
  for being a layout with a single channel set by computing its logarithm.
  Besides being overtly complicated this also has the drawback of relying
  
  on the assumption that every channel name consists of at most seven
  
  uppercase letters only ; but said assumption is wrong : The abbreviation
  
  of the second low frequency channel is LFE2. Furthermore it treats
  
  garbage like "FRfoo" as valid channel.
  This commit changes this by using av_get_channel_layout() directly ;
  
  furthermore, av_get_channel_layout_nb_channels() (which uses popcount)
  
  is used to find out the number of channels instead of the custom code
  
  to calculate the logarithm.
  (As a consequence, certain other formats to specify the channel layouts
  
  are now accepted (like the hex versions of av_get_channel_layout()) ; but
  
  this is actually not bad at all.)
  Reviewed-by : Paul B Mahol <onemda@gmail.com>
  
  Signed-off-by : Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
  

  • [DH] libavfilter/af_headphone.c