Recherche avancée

Sur d’autres sites (12930)

• lavfi : fix race when func rets holder is NULL

  28 mars 2017, par Clément Bœsch

  lavfi : fix race when func rets holder is NULL
  If ret is NULL, a dummy common holder is created to hold *all* the
  
  parallel function returns, which gets written concurrently. This commit
  
  simplify the whole logic by simply not writing to that holder when not
  
  set.
  

  • [DH] libavfilter/pthread.c

• hevc : fix race condition in max_ra/seq_decode.

  24 mai 2017, par Ronald S. Bultje

  hevc : fix race condition in max_ra/seq_decode.
  These variables are shared between frame threads, but they are updated
  
  post-setup_finished() if a EOB/EOS slice type occurs. Moving the EOB/EOS
  
  slices to the next frame thread instance (by parsing them leading into
  
  the next picture instead of trailing behind the last picture) effectively
  
  prevents this race condition.
  This fixes tsan failures on hevc-conformance-NoOutPrior_A_Qualcomm_1.
  

  • [DH] libavcodec/hevc_parser.c
  • [DH] libavcodec/hevcdec.c

• Ffmpeg does not properly convert videos when run as daemon

  20 janvier 2019, par DGoiko

  I’m using ffmpeg to convert and split videos from a Python process. When I run it from console as a normal user everything works as expected, however, if I run it as a daemon it produces the same amount of files but with silence in almost the whole file.

  This is the line I execute from python :

  def convert_to_ffmpeg(file, ffmpeg_folder, chunk_length):
  
      res = -1
  
      try:
  
          file_name = os.path.join(ffmpeg_folder, ntpath.basename(file) + ".flac")
  
          res = os.system("ffmpeg -i " + file + " -f segment -segment_time "+str(chunk_length)+" " + file_name + " -y  >/dev/null 2>&1")
  
      except Exception as e:
  
          raise MyException(code=210005, detalails=file, cause=e)
  
      if not res == 0:
  
          raise MyException(code=210004, detalails=str(res) + " - " + file)
  
      return file_name

  When I run it from a normal console it works as expected : it splits the video in chunks of "self._chunk_length" seconds.

  However, if I run the program using python-daemon with this code :

  if daemon_run:
  
      pid_file = check_unclean_exit(config['pidfile'], log)
  
  
  
      context = daemon.DaemonContext(
  
          working_directory=approot,
  
          umask=0o002,
  
          pidfile=pid_file,
  
      )
  
      context.signal_map = {
  
          signal.SIGTERM: programa_cleanup,
  
          signal.SIGHUP: 'terminate',
  
          # signal.SIGUSR1: reload_program_config,
  
      }
  
  
  
      with context:
  
          convert_to_ffmpeg("/foo/testfile.mkv", "/foo/ffmpeg", 40) 

  It produces EXACTLY the same chunks, however, most of the content of the chunks is just silence. It splits in the proper point, but doesn’t fill the contents of the audio output properly. Of course, no exception is thrown, as ffmpeg always returns 0

  I did even install a completly fresh Debian 9 into a virtual machine to discard problems with ffmpeg and my old-good computer’s setup.

  Of course this is a simplified example. The real thing is a multithread application which watches a directory for files to convert.