Recherche avancée

Sur d’autres sites (3851)

• avfilter/af_amix : Fix double-free of AVFilterChannelLayouts on error

  7 août 2020, par Andreas Rheinhardt

  avfilter/af_amix : Fix double-free of AVFilterChannelLayouts on error
  The query_formats function of the amix filter tries to allocate a list
  
  of channel layouts which are attached to more permanent objects
  
  (an AVFilter's links) for storage afterwards on success. If attaching
  
  a list to a link succeeds, the link becomes one of the common owners
  
  of the list. Yet if a list has been successfully attached to links (or if
  
  there were no links to attach it to in which case
  
  ff_set_common_channel_layouts() already frees the list) and an error
  
  happens lateron, the list was manually freed, which is wrong, because
  
  the list has either already been freed or it is owned by its links in
  
  which case these links' pointers to their list will become dangling and
  
  there will be double-frees/uses-after-free when these links are cleaned
  
  up automatically.
  This commit fixes this by removing the custom freeing code ; this is made
  
  possible by using the list in ff_set_common_channel_layouts() directly
  
  after its allocation (without anything that can fail in between).
  Notice that ff_set_common_channel_layouts() is buggy itself which can
  
  lead to double-frees on error. This is not fixed in this commit.
  Reviewed-by : Nicolas George <george@nsup.org>
  
  Signed-off-by : Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
  

  • [DH] libavfilter/af_amix.c

• avformat/pp_bnk : Fix memleaks when reading non-stereo tracks

  20 mars 2021, par Andreas Rheinhardt

  avformat/pp_bnk : Fix memleaks when reading non-stereo tracks
  Commit 6973df112275c8ea4af0bf3cb1338baecc1d06b3 added support
  
  for music tracks by outputting its two containing tracks
  
  together in one packet. But the actual data is not contiguous
  
  in the file and therefore one can't simply use av_get_packet()
  
  (which has been used before) for it. Therefore the packet was
  
  now allocated via av_new_packet() and read via avio_read() ;
  
  and this is also for non-music files.
  This causes problems because one can now longer rely on things
  
  done automatically by av_get_packet() : It automatically freed
  
  the packet in case of errors ; this lead to memleaks in several
  
  FATE-tests covering this demuxer. Furthermore, in case the data
  
  read is less than the data desired, the returned packet was not
  
  zero-allocated (the packet's padding was uninitialized) ;
  
  for music files the actual data could even be uninitialized.
  The former problems are fixed by using av_get_packet() for
  
  non-music files ; the latter problem is handled by erroring out
  
  unless both tracks could be fully read.
  Reviewed-by : Zane van Iperen <zane@zanevaniperen.com>
  
  Signed-off-by : Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
  

  • [DH] libavformat/pp_bnk.c

• ffmpeg : add option stats_period

  21 décembre 2020, par Gyan Doshi

  ffmpeg : add option stats_period
  At present, progress stats are updated at a hardcoded interval of
  
  half a second. For long processes, this can lead to bloated
  
  logs and progress reports.
  Users can now set a custom period using option -stats_period
  
  Default is kept at 0.5 seconds.
  

  • [DH] doc/ffmpeg.texi
  • [DH] fftools/ffmpeg.c
  • [DH] fftools/ffmpeg.h
  • [DH] fftools/ffmpeg_opt.c