Recherche avancée

Sur d’autres sites (4641)

• avcodec/osq : avoid using too large numbers for shifts and integers in update_residue_...

  14 septembre 2023, par Michael Niedermayer

  avcodec/osq : avoid using too large numbers for shifts and integers in update_residue_parameter()
  Fixes : 2.96539e+09 is outside the range of representable values of type 'int'
  
  Fixes : Assertion n>=0 && n<=32 failed at libavcodec/get_bits.h:423
  
  Fixes : 62241/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_OSQ_fuzzer-4525761925873664
  
  Fixes : 70406/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_OSQ_fuzzer-6545326804434944
  Signed-off-by : Michael Niedermayer <michael@niedermayer.cc>
  

  • [DH] libavcodec/osq.c

• Unable to find correct bash syntax for comparing numbers

  17 octobre 2024, par kali

  Part of a long script I'm simply trying to compare two numbers, one is constant and the other one is retrieved via ffprobe (The 474 in the error messages is the height found by ffprobe)

  


  CURRENT_RES=$(ffprobe -v quiet -select_streams v:0 -show_entries stream=height -of csv=s=x:p=0 "${fn}")
  if [[ $CURRENT_RES -gt 1080 ]]; then
    echo "leaving preset normal"
    SLOW_PRESET=("" "")
  else
    echo "setting preset to slow"
    SLOW_PRESET=(-preset slow)
  fi;


  


  produces :

  


  /usr/local/bin/startScreen.sh: line 95: [[: 474

474: syntax error in expression (error token is "474")
setting preset to slow


  


  I also tried arithmetic operators like :

  


    if (($CURRENT_RES>1080)); then
    echo "leaving preset normal"
    SLOW_PRESET=("" "")
  else
    echo "setting preset to slow"
    SLOW_PRESET=(-preset slow)
  fi;


  


  got a slightly different, but essentially same error message like :

  


  /usr/local/bin/startScreen.sh: line 95: ((: 474

474>1080: syntax error in expression (error token is "474>1080")
setting preset to slow


  


  What's even more baffling is there 15 lines below this block there is another comparison which works perfectly fine !

  


  if [[ $CURRENT_RES -gt $CONVERT_HEIGHT ]]; then


  


  I thought may be the inline written 1080 number is confusing the if expression so I tried assigning 1080 to variable and reusing it, which changed nothing.

  


  edit : (dropping this here in case someone else falls into same mistake)
following up on Shawn's advice from comments using cat -v showed 474 was repeated twice.
For debugging purposes ran :

  


  ffprobe -v quiet -select_streams v:0 -show_entries stream=height -of json "filename.mp4"


  


  to find this weird format :

  


  {
    "programs": [
        {
            "streams": [
                {
                    "height": 472
                }
            ]
        }
    ],
    "streams": [
        {
            "height": 472
        }
    ]
}


  


  finally changed the ffprobe command to :

  


  CURRENT_RES=$(ffprobe -v quiet -select_streams v:0 -show_entries stream=height -of json "${fn}" | jq .streams[0].height)


  


  to resolve the issue.

  


• avformat/mpegts* : reduce use of magic numbers

  1er décembre 2024, par Scott Theisen

  avformat/mpegts* : reduce use of magic numbers
  Note ISO/IEC 13818-1 defines an Extension_descriptor with descriptor_tag value
  
  0x3f (63), so I kept the DVB comment.
  I don't know what defines stream_type value 0x8a as DTS.
  I don't have any Blu-ray standards so I don't know where those stream_type
  
  values are defined.
  Signed-off-by : Marton Balint <cus@passwd.hu>
  

  • [DH] libavformat/mpegts.c
  • [DH] libavformat/mpegts.h
  • [DH] libavformat/mpegtsenc.c