Recherche avancée

Sur d’autres sites (6634)

• libavcodec/jpeg2000 : fix tag tree reset

  27 août 2020, par Gautam Ramakrishnan

  libavcodec/jpeg2000 : fix tag tree reset
  The implementation of the tag tree did not
  
  set the correct reset value for the encoder.
  
  This lead to inefficent tag tree being encoded.
  
  This patch fixes the implementation of the
  
  ff_tag_tree_zero() function.
  Signed-off-by : Michael Niedermayer <michael@niedermayer.cc>
  

  • [DH] libavcodec/j2kenc.c
  • [DH] libavcodec/jpeg2000.c
  • [DH] libavcodec/jpeg2000.h
  • [DH] tests/ref/vsynth/vsynth1-jpeg2000
  • [DH] tests/ref/vsynth/vsynth1-jpeg2000-97
  • [DH] tests/ref/vsynth/vsynth2-jpeg2000
  • [DH] tests/ref/vsynth/vsynth2-jpeg2000-97
  • [DH] tests/ref/vsynth/vsynth3-jpeg2000
  • [DH] tests/ref/vsynth/vsynth3-jpeg2000-97
  • [DH] tests/ref/vsynth/vsynth_lena-jpeg2000
  • [DH] tests/ref/vsynth/vsynth_lena-jpeg2000-97

• avformat/segment : Fix leak and invalid free of AVIOContext

  6 septembre 2020, par Andreas Rheinhardt

  avformat/segment : Fix leak and invalid free of AVIOContext
  seg_init() and seg_write_header() currently contain a few error paths
  
  in which an already opened AVIOContext for the child muxer leaks (namely
  
  if there are unrecognized options for the child muxer or if writing the
  
  header of the child muxer fails) ; the reason for this is that this
  
  AVIOContext is not closed in the deinit function. If all goes well, it
  
  is closed when writing the trailer. From this it also follows that the
  
  AVIOContext also leaks when the trailer is never written, even when
  
  writing the header succeeds.
  But simply freeing said AVIOContext in the deinit function is
  
  complicated by the fact that the AVIOContext may or may not have been
  
  opened via the io_open callback : If options are set to discard header
  
  and trailer, said AVIOContext can also be a null context which must not
  
  be closed via the io_close callback. This may lead to crashes, as
  
  io_close may presume the AVIOContext's opaque to be set. It currently
  
  works with the default io_close callback which simply calls avio_close(),
  
  because avio_close() doesn't care about opaque being NULL since commit
  
  6e8e8431e15a58aa44cfdd8c11f9ea096837c0fa. Therefore this commit records
  
  which of the two kinds of AVIOContext is currently in use to use the
  
  right way to close it.
  Finally there was one instance (namely if initializing the child muxer
  
  fails with no unrecognized options) where the AVIOContext was always
  
  closed via the io_close callback. The above remark applies to this ; it
  
  has been fixed, too.
  Reviewed-by : Ridley Combs <rcombs@rcombs.me>
  
  Signed-off-by : Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
  

  • [DH] libavformat/segment.c

• avfilter/af_aiir : Fix segfault and leak upon allocation failure

  22 août 2020, par Andreas Rheinhardt

  avfilter/af_aiir : Fix segfault and leak upon allocation failure
  The aiir filter adds output pads in its init function. Each of these
  
  output pads had a name which was allocated and to be freed in the uninit
  
  function. Given that the aiir filter has between one and two outputs,
  
  one output pad's name was freed unconditionally and a second was freed
  
  conditionally.
  Yet if adding output pads fails, there are no output pads at all and
  
  trying to free a nonexistent pad's name will lead to a segfault.
  Furthermore, if the name could be successfully allocated, yet adding the
  
  new pad fails, the name would leak.
  This commit fixes this by not allocating the pads' names at all any
  
  more : They are constant anyway. This allows to remove the code to free
  
  them and hence fixes the aforementioned bugs.
  Reviewed-by : Paul B Mahol <onemda@gmail.com>
  
  Signed-off-by : Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
  

  • [DH] libavfilter/af_aiir.c