Recherche avancée

Sur d’autres sites (7291)

• avcodec/omx : Fix handling of fragmented buffers

  17 janvier 2019, par Dave Stevenson

  avcodec/omx : Fix handling of fragmented buffers
  See https://trac.ffmpeg.org/ticket/7687
  If an encoded frame is returned split over two or more
  
  IL buffers due to the size, then there is a race between
  
  whether get_buffer will fail, return NULL, and a truncated
  
  frame is passed on, or IL will return the remaining part
  
  of the encoded frame.
  
  If get_buffer returns NULL, part of the frame is left behind
  
  in the codec, and will be collected on the next call. That
  
  then leaves a frame stuck in the codec. Repeat enough times
  
  and the codec FIFO is full, and the pipeline stalls.
  A performance improvement in the Raspberry Pi firmware means
  
  that the timing has changed, and now frequently drops into the
  
  case where get_buffer returns NULL.
  Add code such that should a buffer be received without
  
  OMX_BUFFERFLAG_ENDOFFRAME that get_buffer is called with wait
  
  set, so we wait for the remainder of the frame.
  
  This code has been made conditional on the Pi build in case
  
  other IL implementations don't handle ENDOFFRAME correctly.
  Signed-off-by : Dave Stevenson <dave.stevenson@raspberrypi.org>
  
  Signed-off-by : Aman Gupta <aman@tmm1.net>
  
  Signed-off-by : Martin Storsjö <martin@martin.st>
  

  • [DH] libavcodec/omx.c

• avformat_open_input crash using ffmpeg on android

  2 octobre 2019, par Timmy K

  I am writing an Android app to capture audio streams from a USB device using ffmpeg, and mux them into an m4a file. I then open the recording file to read back the audio data. The app works fine on Samsung S8 (Android 8.0) and S9 (Android 9.0). On a Moto G5+ (Android 8.1), however the app crashes inside avformat_open_input() when I try to open the recording file ; but if I restart the app and it reads the same file with the same code, it works without crashing.

  I thought maybe that I hadn’t closed the recording file properly ; or there was maybe a race condition : trying to read the file before it was written. However I have established that av_write_trailer() is called successfully and avio_closep() is called successfully before the call to avformat_open_input. I also established that the length of the file is the same just before the call to avformat_open_input() in the crash case as it is in the non-crash case.

  The code that finishes the recording :

  // AVFormatContext *mAvFormatContext
  
  // ...
  
  int ret = av_write_trailer(mAvFormatContext);
  
  if ( ret != 0 )
  
  {
  
      __android_log_print(ANDROID_LOG_DEBUG, "MyTag", "failed to write trailer %s", av_err2str( ret ) );
  
      goto fail;
  
  }
  
  
  
  ret = avio_close( mAvFormatContext->pb );
  
  if ( ret < 0 )
  
  {
  
      __android_log_print(ANDROID_LOG_DEBUG, "MyTag", "failed to avio_close %s", av_err2str( ret ) );
  
      goto fail;
  
  }
  
  
  
  avformat_free_context(mAvFormatContext);

  The call that causes a crash immediately after the above code, on a Moto 5G+ (but not Samsung S8/S9) :

  mAvFormatContext = nullptr;
  
  if ( (ret = avformat_open_input( &mAvFormatContext, filePath, 0, 0)) < 0 )
  
  {
  
      __android_log_print(ANDROID_LOG_DEBUG, "MyTag++", "Could not open input file '%s' error %s ", filePath, av_err2str(ret) );
  
      cleanup();
  
      return false;
  
  }

  Also, when the call to avformat_open_input() does not crash, there is no output in logcat from within that call. However, I’ve noticed that in the crash case there is output of what seems to be corrupted data :

  2019-09-02 09:39:14.105 19999-19999/fm.x.y D/AudioEngine: Opening '@�7���-d��@�7�' for 
  
  2019-09-02 09:39:14.106 19999-19999/fm.x.y D/AudioEngine: Setting default whitelist '<��'
  
  2019-09-02 09:39:14.106 19999-19999/fm.x.y D/AudioEngine: Probing ���d score:-1828887548 size:-1093138844
  
  2019-09-02 09:39:14.106 19999-19999/fm.x.y D/AudioEngine: Format ��� probed with size=-1093138756 and score=-1093138748
  
  (crash occurs)

  Any advice on what to look into further to investigate this problem ? Is there something I am missing when cleaning up the muxing state before I try to open the recording file for demuxing ? For simplicity I have not included the freeing of codec contexts, AVFrames and AVPackets.

• Alfresco fails to create video thumbnail

  17 octobre 2019, par Deckard

  As error log says : Empty input file ... It turned out that the source image for ImageMagick is zero sized. (/data/was/alfresco/tomcat/temp/Alfresco/ImageMagickContentTransformerWorker_source_8718262212685093199.jpg). When I manually replace the source image to normal image and execute the command again, there’s no error.

  command:    /data/was/alfresco/common/bin/convert /data/was/alfresco/tomcat/temp/Alfresco/ImageMagickContentTransformerWorker_source_8718262212685093199.jpg[0] -auto-orient -resize "100x100>" -strip -quiet /data/was/alfresco/tomcat/temp/Alfresco/ImageMagickContentTransformerWorker_target_7652060684136589026.png

  So I think the source image is maybe made by FFMPEG by capturing some frame of the video.
  And the FFMPEG somehow failed to do it. Not sure my guess is right...

  But my FFMPEG works good as ffmpeg -version shows proper version info. And FFMPEG is run by root and the Alfresco daemon instance is run by root. It seems that there’s nothing wrong.

  Please review it. Here’s the whole Alfresco-share log :

  Caused by: org.alfresco.service.cmr.repository.ContentIOException: 09160037 Content conversion failed:
  
     reader: ContentAccessor[ contentUrl=store:///data/was/alfresco/tomcat/temp/Alfresco/ComplextTransformer_intermediate_mp4_262176879279399174.jpg, mimetype=image/jpeg, size=0, encoding=UTF-8, locale=en_US]
  
     writer: ContentAccessor[ contentUrl=store:///data/was/alfresco/tomcat/temp/Alfresco/FailoverTransformer_intermediate_ComplexContentTransformer_5223852355212570043.png, mimetype=image/png, size=0, encoding=UTF-8, locale=en_US]
  
     options: {use=doclib, contentReaderNodeRef=null, contentWriterNodeRef=null, sourceContentProperty=null, imageAutoOrient=true, targetContentProperty=null, commandOptions=, imageResizeOptions=ImageResizeOptions [width=100, height=100, maintainAspectRatio=true, percentResize=false, resizeToThumbnail=false, allowEnlargement=false], includeEmbedded=null}
  
     limits: {timeoutMs=120000, pageLimit=1}
  
          at org.alfresco.repo.content.transform.AbstractContentTransformer2.transform(AbstractContentTransformer2.java:350)
  
          at org.alfresco.repo.content.transform.ComplexContentTransformer.transformInternal(ComplexContentTransformer.java:492)
  
          at org.alfresco.repo.content.transform.AbstractContentTransformer2.transform(AbstractContentTransformer2.java:272)
  
          ... 32 more
  
  Caused by: org.alfresco.service.cmr.repository.ContentIOException: 09160036 Failed to perform ImageMagick transformation:
  
  Execution result:
  
     os:         Linux
  
     command:    /data/was/alfresco/common/bin/convert /data/was/alfresco/tomcat/temp/Alfresco/ImageMagickContentTransformerWorker_source_8718262212685093199.jpg[0] -auto-orient -resize "100x100>" -strip -quiet /data/was/alfresco/tomcat/temp/Alfresco/ImageMagickContentTransformerWorker_target_7652060684136589026.png
  
     succeeded:  false
  
     exit code:  1
  
     out:
  
     err:        .convert.bin: Empty input file `/data/was/alfresco/tomcat/temp/Alfresco/ImageMagickContentTransformerWorker_source_8718262212685093199.jpg' @ error/jpeg.c/JPEGErrorHandler/331.
  
  .convert.bin: NoImageForProperty "%w" @ warning/property
  
          at org.alfresco.repo.content.transform.magick.ImageMagickContentTransformerWorker.transformInternal(ImageMagickContentTransformerWorker.java:205)
  
          at org.alfresco.repo.content.transform.magick.AbstractImageMagickContentTransformerWorker.transform(AbstractImageMagickContentTransformerWorker.java:284)
  
          at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
  
          at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
  
          at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
  
          at java.lang.reflect.Method.invoke(Method.java:498)
  
          at org.alfresco.repo.management.subsystems.SubsystemProxyFactory$1.invoke(SubsystemProxyFactory.java:79)
  
          at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172)
  
          at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204)
  
          at com.sun.proxy.$Proxy28.transform(Unknown Source)
  
          at org.alfresco.repo.content.transform.ProxyContentTransformer.transformInternal(ProxyContentTransformer.java:107)
  
          at org.alfresco.repo.content.transform.AbstractContentTransformer2.transform(AbstractContentTransformer2.java:272)
  
          ... 34 more

  In alfresco-global.properties : ffmpeg.exe=/usr/local/bin/ffmpeg/ffmpeg

  * Update As Robert suggested, TransFormer log level changed to debug.
  But the log is too long to paste here. There’s 30,000 characters limit of body in SO which github doesn’t have.
  So please refer to github issue, I pasted the log there.
  https://github.com/Alfresco/share/issues/127