Recherche avancée

Sur d’autres sites (5368)

• avformat/dashdec : Fix crash on invalid input/ENOMEM, fix leak

  20 septembre 2022, par Andreas Rheinhardt

  avformat/dashdec : Fix crash on invalid input/ENOMEM, fix leak
  In case a SupplementalProperty node exists in an adaptationset,
  
  it is searched for a "schemeIdUri" property via xmlGetProp().
  
  Whatever xmlGetProp() returns is then compared via av_strcasecmp()
  
  to a string literal. xmlGetProp() can return NULL, namely in case
  
  no "schemeIdUri" exists and (given that this string is allocated)
  
  presumably also on allocation failure. No check for NULL is done,
  
  so this may crash.
  Furthermore, the string returned by xmlGetProp() needs to be freed
  
  with xmlFree(), but this is not done either.
  This commit fixes both of these issues ; they existed since this code
  
  has been added in 10d008f0fd9e713e290f626300d66382ad786c49.
  This has been found while investigating ticket #9697. The continuous
  
  leaks might very well be the reason behind the observed slowdown.
  Reviewed-by : Steven Liu <lingjiujianke@gmail.com>
  
  Signed-off-by : Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
  

  • [DH] libavformat/dashdec.c

• Does this code contain a potential memory leak ?

  26 juillet 2017, par Johnnylin

  Here is the code :

  cv::Mat YV12ToBRG24_FFmpeg(unsigned char* pYUV, int width,int height)
  
  {
  
      if (width < 1 || height < 1 || pYUV == nullptr){
  
          return cv::Mat();
  
      }
  
  
  
      cv::Mat result(height,width,CV_8UC3, cv::Scalar::all(0));
  
      uchar* pBGR24 = result.data;
  
  
  
      AVFrame* pFrameYUV = av_frame_alloc();
  
      pFrameYUV->width = width;
  
      pFrameYUV->height = height;
  
      pFrameYUV->format = AV_PIX_FMT_YUV420P;
  
      av_image_fill_arrays(pFrameYUV->data, pFrameYUV->linesize, pYUV, AV_PIX_FMT_YUV420P, width, height, 1);
  
  
  
      //U,V exchange
  
      uint8_t * ptmp=pFrameYUV->data[1];
  
      pFrameYUV->data[1]=pFrameYUV->data[2];
  
      pFrameYUV->data[2]=ptmp;
  
  
  
      AVFrame* pFrameBGR = av_frame_alloc();
  
      pFrameBGR->width = width;
  
      pFrameBGR->height = height;
  
      pFrameBGR->format = AV_PIX_FMT_BGR24;
  
      av_image_fill_arrays(pFrameBGR->data, pFrameBGR->linesize, pBGR24, AV_PIX_FMT_BGR24, width, height, 1);
  
  
  
      struct SwsContext* imgCtx = nullptr;
  
      imgCtx = sws_getContext(width,height,AV_PIX_FMT_YUV420P,width,height,AV_PIX_FMT_BGR24,SWS_BILINEAR,0,0,0);
  
      if (imgCtx != nullptr){
  
          sws_scale(imgCtx,pFrameYUV->data,pFrameYUV->linesize,0,height,pFrameBGR->data,pFrameBGR->linesize);
  
          sws_freeContext(imgCtx);
  
          imgCtx = nullptr;
  
          ptmp = nullptr;
  
          pBGR24 = nullptr;
  
          av_frame_free(&pFrameYUV);
  
          av_frame_free(&pFrameBGR);
  
          return result;
  
      }
  
      else{
  
          sws_freeContext(imgCtx);
  
          imgCtx = nullptr;
  
          ptmp = nullptr;
  
          pBGR24 = nullptr;
  
          av_frame_free(&pFrameYUV);
  
          av_frame_free(&pFrameBGR);
  
          return cv::Mat();
  
      }
  
  }

  This function is called every 40 ms (25 fps) and I saw a significant memory increase after several days(like 12GB). But if I ran this code for hours, the memory leak problem would not be obvious enough to be observed.

  Can anyone help ?
  Thanks.

• avformat/hevc : Fix potential leak in case of ff_hevc_annexb2mp4_buf failure

  23 janvier 2020, par Andreas Rheinhardt

  avformat/hevc : Fix potential leak in case of ff_hevc_annexb2mp4_buf failure
  ff_hevc_annexb2mp4_buf() could indicate an error, yet leave cleaning
  
  after itself to the caller, so that a caller could not simply return the
  
  error, but had to free the buffer first.
  (Given that all current callers have set filter_ps = 0, this error can
  
  currently not be triggered.)
  Signed-off-by : Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
  
  Signed-off-by : James Almer <jamrial@gmail.com>
  

  • [DH] libavformat/hevc.c
  • [DH] libavformat/hevc.h